doc fix
(1) By marcusatiliusregulus on 2021-01-23 11:25:34 [source]
i just cant figure out how to send a pull request here/with fossil... diff -u pikchr/doc/pathattr.md pathattr.md --- pikchr/doc/pathattr.md 2021-01-23 12:08:44.434861820 +0100 +++ pathattr.md 2021-01-23 12:07:39.006311491 +0100 @@ -30,7 +30,7 @@ matter. But the order of the various "to" subclauses do matter, of course. If there are two consecutive *direction* clauses (*direction* is -always one of "`right`", "`down`", "`left`", or "`right`") then +always one of "`up`", "`down`", "`left`", or "`right`") then the two will be combined to specify a single line segment. Hence, the following are equivalent:
(2) By Warren Young (wyoung) on 2021-01-23 12:05:08 in reply to 1 [link] [source]
i just cant figure out how to send a pull request here/with fossil...
always one of "
up", "down", "left", or "right") then
Applied; thanks!
(3) By marcusatiliusregulus on 2021-01-23 12:51:36 in reply to 2 [link] [source]
Here you go.
Thank you very much; it seems I almost got it right :), will use fossils diff next time...
(4) By Warren Young (wyoung) on 2021-01-24 01:31:44 in reply to 3 [link] [source]
You seem to be missing the major point in the contribution doc I linked, which is not the precise format of the patch file, but the fact that we don't accept drive-by patches as a rule at all.
I applied yours as-is only on the "trivial patch" rule. You could've just said "you repeated the word 'right' twice in this doc here" and I'd have been able to replicate your patch. That makes it trivial in my book, at least.
(I don't mean that as demeaning, just saying that we don't need the full ceremony for such cases. We do appreciate your bothering to find and report such problems!)
If you ever want to submit substantial changes, then you'll need to go through the rest of that doc's processes, including submitting a signed CLA.
At that point, you'll receive direct commit access, so you won't need patches or PRs.
(5) By marcusatiliusregulus on 2021-01-24 02:45:27 in reply to 4 [link] [source]
fine with me, i'll most likely only point out documentation typos anyways.
(6) By Steen (jshoyer) on 2021-01-27 14:52:25 in reply to 4 [link] [source]
Recent check-in d0943cba6cb58f35 introduced a minor mis-spelling near the end of the user manual (line 1312).
I find the mis-spelling slightly poetic: writin' can feel like writhin'. But the sentence should read “written using Markdown”.